Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Active viewpoint should not be closed when the annotated page is reloaded #81

Open
benel opened this issue Apr 25, 2019 · 3 comments
Open
Labels

Comments

@benel
Copy link
Member

benel commented Apr 25, 2019

This fix seems to be necessary when annotating Cassandre v3 pages, since they are automatically reloaded.

@christophe-lejeune Are Cassandre pages reloaded on a timer or only on update (#76)?

@benel benel added the Fix label Apr 25, 2019
@benel
Copy link
Member Author

benel commented Apr 26, 2019

I cannot reproduce this problematic behavior... I only saw it that on Valentin's desktop. Any idea why?

@benel
Copy link
Member Author

benel commented Apr 26, 2019

Or maybe I was just unlucky and there were people editing a memo at the very same time?

@christophe-lejeune
Copy link
Member

Cassandre is intended to refresh the page in two different situations :

  • You are reading a memo and it is updated by someone else (such a reload does not occur if you are modifying the memo, composing a comment or editing the title of the memo).
  • You are browsing the diary page and one of the belonging memos is updated (or a new one is created).

In practice, I have been experienced reloads even in my personal diaries (whose I am the only allowed contributor). Other users confirm to have observed this behavior. This means that Cassandre sometimes refreshes the page even when none of the conditions above are encountered. I suspect the way events are filtered is not restrictive enough... but I have not investigated further. Such reloads remain reasonable, so that no user complain about them.

Of course, this code could evolve in a way facilitating interactions with LaSuli.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants