Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes Audio Config - deprecate DTS and Auro #978

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SteveLLamb
Copy link
Collaborator

Line up info with Illustrated Guide, closes #972

Copy link
Contributor

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the opportunity to add a deprecated flag to the schema for that register.

@SteveLLamb
Copy link
Collaborator Author

We should use the opportunity to add a deprecated flag to the schema for that register.

Oh good point, also adding in the replaced by, since we have that for ATMOS.

@SteveLLamb SteveLLamb marked this pull request as draft September 23, 2024 22:36
@SteveLLamb SteveLLamb marked this pull request as ready for review September 24, 2024 16:41
@SteveLLamb
Copy link
Collaborator Author

SteveLLamb commented Sep 24, 2024

We should use the opportunity to add a deprecated flag to the schema for that register.

@palemieux Addressed in 995cd7c

@palemieux
Copy link
Contributor

The deprecation flags should be validated in https://github.com/ISDCF/registries/blob/master/src/main/scripts/audioconfigs.validate.js as they are at:

(registry[i].obsoletedBy||[]).forEach(obs => {

@SteveLLamb
Copy link
Collaborator Author

The deprecation flags should be validated in https://github.com/ISDCF/registries/blob/master/src/main/scripts/audioconfigs.validate.js as they are at:

(registry[i].obsoletedBy||[]).forEach(obs => {

So the difference with the Audio, is that not all deprecated have a replacement, such as Auro and DTSX. Studios are required to have a pointer to new Studio, we don't really use that flag the same way there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DTS X and Auro Deprecation Update
2 participants