Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging in TranscriptProcessor.check_transcription_file() #64

Open
Tracked by #62
chrisbrickhouse opened this issue Aug 29, 2022 · 0 comments
Open
Tracked by #62

Improve logging in TranscriptProcessor.check_transcription_file() #64

chrisbrickhouse opened this issue Aug 29, 2022 · 0 comments
Labels
documentation Primarily related to documenting usage or code enhancement Improve an existing feature
Milestone
Version 2.1

Comments

@chrisbrickhouse
Copy link
Collaborator

The function aligner.TranscriptProcessor.check_transcription_file() marks lines which need removal but does not log these problem lines nor does it notify the user. Not dealing with these lines can cause the alignment to fail (see #63), making debugging the problem difficult even though FAVE knows exactly where the problem is. Logging should be improved so that the lines-at-issue can be tracked down and fixed easily.
This was referenced Aug 29, 2022
Open
Closed
@chrisbrickhouse chrisbrickhouse added this to the Version 2.1 milestone Sep 23, 2022
@chrisbrickhouse chrisbrickhouse added enhancement Improve an existing feature documentation Primarily related to documenting usage or code labels Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Primarily related to documenting usage or code enhancement Improve an existing feature
Projects
None yet
Milestone
Version 2.1
Development

No branches or pull requests
1 participant
@chrisbrickhouse