-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup header documentation #76
Comments
It looks like an old change log, but without dates (blame says it was you and Kyle who added them across two commits). We could stash it in a CHANGELOG.md file and/or on a Sphinx page, and this could be updated with future change logs (we should probably have this anyway). I'm not sure how useful preserving this comment block would be given that it's available in the commit history and at least 9 years old, but I don't see much harm. |
The comment block was actually written by Ingrid Rosenfelder, and the two commits would have been the original commit to github, Kyle's commit was from running autopep8. While there's some changelog components, it also contains documentation. Most important, I think, are this description of the default measurement point selection procedure:
And this discussion of tokens excluded from analysis:
Edit: It might be silly, but I almost want to save |
Ah okay, I wasn't sure if those were documentation or just really brief change log entries. Those seem worth adding to the top-level doc string.
I'm down for that. We should keep it as an inline comment though. If we add it to the doc string, it will get added to the Sphinx docs which could confuse people. |
Oh, we also have NEWS.md where we can stash most of the changelog stuff, right? |
The top of
extractFormants.py
has a large comment block that should be preserved somewhere, but is more appropriate in some more visible and (and updatable) documentation.The text was updated successfully, but these errors were encountered: