Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Add a Vue integration for konami-emoji-blast #323

Open
2 tasks done
JoshuaKGoldberg opened this issue Apr 29, 2024 · 1 comment
Open
2 tasks done

🚀 Feature: Add a Vue integration for konami-emoji-blast #323

JoshuaKGoldberg opened this issue Apr 29, 2024 · 1 comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Apr 29, 2024

Bug Report Checklist

Overview

Splitting out of #317: this monorepo currently has a @konami-emoji-blast/react package that integrates konami-emoji-blast with React. Let's add an equivalent for Vue!

@danielroe drove creating https://github.com/danielroe/nuxt-emoji-blast, which prototypes it nicely. https://github.com/danielroe/nuxt-emoji-blast/blob/135c90f027f1046b1fff624ca1df23cae7b2582e/src/runtime/composables/konami.ts in particular I think?

I have very little Vue experience so I'm not confident in these matters.

Additional Info

Note that this isn't a good first issue. It might end up being a tricky thing to implement, since you have to understand the equivalent of component/composable lifecycles in Vue (#322) and Nuxt.

Co-authored-by: @danielroe

💖

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀 labels Apr 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Feature: Add a Nuxt integration for konami-emoji-blast 🚀 Feature: Add a Vue integration for konami-emoji-blast Aug 10, 2024
@JoshuaKGoldberg
Copy link
Owner Author

#317 -> #322 ended up just adding a Nuxt integration, not a Vue one. So this issue should remain open for a Vue integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

No branches or pull requests

1 participant