Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config not passed along when concatenating with string #279

Open
etibarg opened this issue Feb 3, 2023 · 0 comments
Open

Config not passed along when concatenating with string #279

etibarg opened this issue Feb 3, 2023 · 0 comments

Comments

@etibarg
Copy link

etibarg commented Feb 3, 2023

Hi,

Using FilePathsBase concat method * does not pass along S3Path config. So I've ended up coding the following:

using AWSS3: S3Path
function Base.:(*)(fp::S3Path, str::AbstractString)
    S3Path(convert(String, fp) * str; config=fp.config)
end

Maybe there's a security reason I don't see that could justify not implementing this method?
I mean, we already have access to credentials in fp, so ...

Or is it just in line with #226?
e.g., the need to implement S3Path type-specific methods

Btw, using S3Path like a filesystem and not just a key-value store is sooo convenient.

Rgds,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant