Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Table Height when Displaying in REPL (w/ Blink) #14

Open
jacobadenbaum opened this issue Mar 6, 2019 · 2 comments
Open

Incorrect Table Height when Displaying in REPL (w/ Blink) #14

jacobadenbaum opened this issue Mar 6, 2019 · 2 comments

Comments

@jacobadenbaum
Copy link

When displaying the table in the REPL using blink (as suggested in the README), the table doesn't scale to fit the window, which can be annoying if you want to resize it/move it around, etc...

It looks like this is because the default behavior is to set the height to a fixed number. I think this can be fixed by setting height = "100vh" (see this answer on stack overflow).

Should this (or something like it) be the default?

@pfitzseb
Copy link
Member

pfitzseb commented Mar 7, 2019

No, this unfortunately can't be the default behaviour because it breaks in other contexts (e.g. Jupyter).

I guess we could try to make the defaults context sensitive (i.e. try to figure out where we're being run and set the defaults accordingly), but imho that's the wrong solution.
There probably is a clean solution to this, but a) not with the current WebIO and b) I can't figure it out.

@jacobadenbaum
Copy link
Author

Yeah, I figured it must be something like that. I would up wrapping the correct solution that makes a blink window and populates it output that has autoscaling height in a little 10 line package in case anyone else is annoyed by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants