This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
Move to a single macro, @auto_hash_equals, and keyword options.
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 89.34% 93.46% +4.11%
==========================================
Files 1 2 +1
Lines 169 199 +30
==========================================
+ Hits 151 186 +35
+ Misses 18 13 -5
☔ View full report in Codecov by Sentry. |
Remove support for placing the macro on a block containing a struct. It didn't work correctly (throwing away the rest of the block).
mcmcgrath13
reviewed
Aug 9, 2023
mcmcgrath13
reviewed
Aug 9, 2023
mcmcgrath13
reviewed
Aug 9, 2023
mcmcgrath13
reviewed
Aug 9, 2023
mcmcgrath13
reviewed
Aug 9, 2023
mcmcgrath13
reviewed
Aug 9, 2023
mcmcgrath13
reviewed
Aug 9, 2023
|
@mcmcgrath13 I think I've addressed all of your comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.