Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also parse the host from VPC style urls #50

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Also parse the host from VPC style urls #50

merged 2 commits into from
Jan 24, 2024

Conversation

Drvi
Copy link
Member

@Drvi Drvi commented Jan 24, 2024

No description provided.

@Drvi Drvi requested review from NHDaly and quinnj January 24, 2024 17:52
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @Drvi! 👍

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c8f299) 84.37% compared to head (03c0788) 84.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files           7        7           
  Lines         659      659           
=======================================
  Hits          556      556           
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Drvi Drvi merged commit 8671f8a into main Jan 24, 2024
7 checks passed
@Drvi Drvi deleted the td-parse-vpc-hosts branch January 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants