Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update compat for Rmath_jll to 0.4, 0.5 #87

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

longemen3000
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.49%. Comparing base (f602e42) to head (bb77fdb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   69.49%   69.49%           
=======================================
  Files           1        1           
  Lines         177      177           
=======================================
  Hits          123      123           
  Misses         54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack andreasnoack merged commit 86d1d0a into JuliaStats:master Sep 10, 2024
5 checks passed
@ViralBShah
Copy link
Contributor

@andreasnoack Should we not require 0.5.1 as the minimum here to avoid the bug that was just fixed in Rmath?

@andreasnoack
Copy link
Member

It has been argued to me in the past that bug fixes in dependencies should result in a change of the compact bound unless e.g. it is required for the package to load. I bought the argument at the time but I think there are divergent views on this matter.

@ViralBShah
Copy link
Contributor

I feel that we should push for correctness by default in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants