Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow authentication on POST requests #14

Open
axellorreyne opened this issue Mar 17, 2023 · 0 comments
Open

Allow authentication on POST requests #14

axellorreyne opened this issue Mar 17, 2023 · 0 comments

Comments

@axellorreyne
Copy link
Contributor

axellorreyne commented Mar 17, 2023

At this time, the extension will only add authentication to GET requests.
POST requests will not be blocked, but won't have any authentication either.

This is because, the (blocking) web request listener that catches any outgoing request from the browser user,
will catch any outgoing requests from the extension background script as well,
specifically POST request requesting the token url and requesting access tokens from said url.

To prevent an infinite loop of blocking web request listeners catching each other, any POST request that is caught, will be passed
before any token url or access token is requested, and consequently any authentication is added.

A more elegant way of catching and passing these two specific requests should be implemented, so that user POST requests can also be authenticated without creating an infinite loop.

@pheyvaer pheyvaer changed the title Allow authentication on POST request's Allow authentication on POST requests Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant