Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 NMEA Version #217

Open
daguzma7 opened this issue May 5, 2023 · 0 comments
Open

ROS2 NMEA Version #217

daguzma7 opened this issue May 5, 2023 · 0 comments

Comments

@daguzma7
Copy link

daguzma7 commented May 5, 2023

Describe the bug
While gathering ROS parameters in ublox_gps/src/node.cpp the configuration for nmea does not include "version".

To Reproduce
Checkout the ros2 branch.
https://github.com/KumarRobotics/ublox/blob/ros2/ublox_gps/src/node.cpp#L389

Steps to reproduce the behavior:

  1. Go to ublox_gps/src/node.cpp:
    Around ~389:
  // NMEA parameters
  this->declare_parameter("nmea.set", false);
  this->declare_parameter("nmea.compat", false);
  this->declare_parameter("nmea.consider", false);
  this->declare_parameter("nmea.limit82", false);
  this->declare_parameter("nmea.high_prec", false);
  this->declare_parameter("nmea.filter.pos", false);
  this->declare_parameter("nmea.filter.msk_pos", false);
  this->declare_parameter("nmea.filter.time", false);
  this->declare_parameter("nmea.filter.date", false);
  this->declare_parameter("nmea.filter.sbas", false);
  this->declare_parameter("nmea.filter.track", false);
  this->declare_parameter("nmea.filter.gps_only", false);
  this->declare_parameter("nmea.gnssToFilter.gps", false);
  this->declare_parameter("nmea.gnssToFilter.sbas", false);
  this->declare_parameter("nmea.gnssToFilter.qzss", false);
  this->declare_parameter("nmea.gnssToFilter.glonass", false);
  this->declare_parameter("nmea.gnssToFilter.beidou", false);
  1. Add this to parameter file:
nmea:
      set: false
      version: 65

Expected behavior
I expect the version to be taken into consideration because it is required when nmea is set true.

Desktop (please complete the following information):

  • OS: [Ubuntu 22.02 LTS]
  • ROS Version [ROS2 Humble]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant