Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreachable node setup lines with HPS devices #242

Open
Barackbar opened this issue May 3, 2024 · 0 comments
Open

Unreachable node setup lines with HPS devices #242

Barackbar opened this issue May 3, 2024 · 0 comments

Comments

@Barackbar
Copy link

Line 226 in node.cpp renders line 235 unreachable.
The result of this is that HPS devices (like the ZED-F9R) only get HpPosRec functionality and no AdrUdr functionality.

Furthermore, line 235 uses the HpgRov class instead of HpPosRec class like in 226.
It should be determined which is the appropriate class to use with HPS devices.

Lines in question:

} else if (product_category == "HPG" || product_category == "HPS") {

} else if (product_category == "HPS") {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant