Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature ] remove VueDarMode dependency so that support CDNJS . #15

Open
625781186 opened this issue Aug 11, 2020 · 2 comments
Open

[feature ] remove VueDarMode dependency so that support CDNJS . #15

625781186 opened this issue Aug 11, 2020 · 2 comments

Comments

@625781186
Copy link

625781186 commented Aug 11, 2020 •
edited
Loading

, It doesn't work for CDNJS.

<html lang="en"><head>
   <!-- ----------------------------------- -->
   <meta charset="UTF-8">
   <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0">
   <meta http-equiv="X-UA-Compatible" content="ie=edge,chrome=1">
   <meta name="keywords" content=" ">    
   <meta name="description" content=" ">     
   <meta name="author" content=" ">       

   <!-- ----------------------------------- -->
   

   <!-- ----------------------------------- -->
   <title></title>
   
   <!-- ----------------------------------- -->
                                         

   
   <!-- ----------------------------------- -->
   

   <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/vue.min.js"></script>



   <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/v-click-outside.umd.min.js"></script>
   <script src="https://cdn.jsdelivr.net/npm/@growthbunker/vuedarkmode@latest/dist/vuedarkmode.min.js"></script>
   <script src="https://cdn.jsdelivr.net/npm/@growthbunker/[email protected]/dist/vuetimeline.min.js"></script>
                                        
</head>
<body>
<!-- ----------------------------------- -->

   <div id="app">
      <h1>[[test]]</h1>
      <template>
         <!-- Latest update -->
         <vue-timeline-update :date="new Date('2017-02-26')" title="v2.2.0 - Initial D" description="Today I am thrilled to announce the release of Vue.js 2.2.0." thumbnail="/images/vuetimeline/initial_d.jpg" category="announcement" icon="code" color="red">

         <!-- Another update -->
         <vue-timeline-update :date="new Date('2016-11-22')" title="v2.1.0 - Hunter X Hunter" description="Today I am thrilled to announce the release of Vue.js 2.1.0." thumbnail="/images/vuetimeline/hunter_x_hunter.jpg" category="announcement" icon="code" color="turquoise">

         <!-- Yet another update -->
         <vue-timeline-update :date="new Date('2016-09-30')" title="v2.0.0 - Ghost in the Shell" description="Today I am thrilled to announce the release of Vue.js 2.0.0" thumbnail="/images/vuetimeline/ghost_in_the_shell.jpg" category="announcement" icon="code" color="white" is-last="">
      </vue-timeline-update></vue-timeline-update></vue-timeline-update></template>   </div>
                                          

<!-- ----------------------------------- -->


   <!--<editor-fold desc="vue ... 脚本">-->
   <!---->
   <script>

       
       Vue.use(vClickOutside)
       Vue.use(VueDarkMode)
       Vue.use(vuetimeline);
       
       
       window.vm1 = new Vue({
           el        : '#app',
           delimiters: ['[[',
                        ']]',
           ],
           components: {},
           mixins    : [],

           data() {
               return {
                   VueDarkMode:false,
                   test: "!11",
               }
           },
           mounted() {


           },
           methods: {},

       })
   </script>
   <!--</editor-fold>-->
                                               


</body></html>

image
@LeCoupa
Copy link
Owner

LeCoupa commented Aug 11, 2020

Yes, you are right. It is preferable to only use the npm package version for the time being.

@625781186 625781186 reopened this Aug 11, 2020
@625781186 625781186 changed the title It doesn't seem to work for CDNJS development because of the lack of dependencies. [feature ] remove VueDarMode dependency so that support CDNJS . Aug 11, 2020
@kingyue737
Copy link

Screenshot 2021-11-17 202203

VueDarkMode is so large. Hope that it can be removed and allow customized icon slot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeCoupa @625781186 @kingyue737