Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Guitar Gallery Page the Root Route of the Application #17

Open
LiorKGOW opened this issue Nov 3, 2022 · 0 comments · May be fixed by #16
Open

Make the Guitar Gallery Page the Root Route of the Application #17

LiorKGOW opened this issue Nov 3, 2022 · 0 comments · May be fixed by #16

Comments

@LiorKGOW
Copy link
Owner

LiorKGOW commented Nov 3, 2022 •
edited
Loading

If we go to http://127.0.0.1:3000/ it already shows the guitar app,
we can remove the home_controller and also app/views/home/index.html.erb
and keep only the guitars controller for now.
It's good that we display it as the root page since we don't have login/welcome page
( as mentioned by @Ron-Lavi in #8 )

  • This PR is Ruby related
@LiorKGOW LiorKGOW linked a pull request Dec 21, 2022 that will close this issue
Making guitars root route prob #16
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Making guitars root route prob LiorKGOW/My-Guitar-Store
1 participant
@LiorKGOW