Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Elytra/Chestplates to carry over Custom Enchantments #39

Open
EchocallingEarth opened this issue Oct 9, 2021 · 3 comments
Labels
status: ☑️ accepted This issue or pull request is accepted as valid type: 🎯 feature New feature or request
Milestone

Comments

@EchocallingEarth
Copy link

The ability to carry over custom enchantments.

Meaning that if a chestplate is enchanted with 'ExampleX' it will carry over to the Elytra when combined.

Currently, only vanilla enchantment carry over and that makes using some custom enchantments pointless and rather frustrating to players who discover their hard-earned custom enchantment is broken when combining Elytra and chestplates.

Adding this feature would make the use of this function highly sought after on any servers using custom enchanting plugins like AdvancedEnchants, Crazy Enchantments, and many more

I can try to explain better what I mean however I think the concept is clear. Or at least I hope it is.

Thanks for all you hard work and I really hope this can be implemented. Anything I can do to help make this possible feel free to reach out to me here or on Discord EchocallingEarth#0001

@EchocallingEarth EchocallingEarth changed the title Adding to Elytra+chestplate option Enhancement Elytra/Chestplates to carry over Custom Enchantments Oct 9, 2021
@Machine-Maker Machine-Maker added the type: 🎯 feature New feature or request label Oct 9, 2021
@Machine-Maker
Copy link
Member

Sounds like good idea, but each of these enchantment plugins go about adding enchants in a different way, so I can't do all of them. What are the most used ones?

@EchocallingEarth
Copy link
Author

The most common is AdvancedEnchantments.

AdvancedEnchantments has the most actively involved Dev and community from what I have found.

There are others however I have checked a few and in at least 1 case the plugin is not updated. In another case, the dev warns about using on a production server and the final one is much much smaller and does not seem to have a large following.

Now with all that said I would recommend AdvancedEnchantments, I have tested and use others but this is, in my opinion, the best.

If there is anything I can do to further assist do not hesitate to ask.

@Machine-Maker Machine-Maker added the status: ☑️ accepted This issue or pull request is accepted as valid label Nov 4, 2021
@Machine-Maker Machine-Maker added this to the 0.2.x milestone Nov 4, 2021
@ElFrod0
Copy link

ElFrod0 commented Dec 23, 2022

@Machine-Maker I highly recommend copying over NBT tags. Many plugins do not even register enchantments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ☑️ accepted This issue or pull request is accepted as valid type: 🎯 feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants