Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapserver source: msLoadMap takes a new parameter #326

Open
mamaar opened this issue Dec 15, 2023 · 2 comments
Open

Mapserver source: msLoadMap takes a new parameter #326

mamaar opened this issue Dec 15, 2023 · 2 comments

Comments

@mamaar
Copy link

mamaar commented Dec 15, 2023

Since this commit: MapServer/MapServer@f478a37
MapServer seems to take a new parameter for config. The MapServer source in Mapcache has not been updated to reflect this change:

My guess is that the new parameter could just take a NULL when called from Mapcache. If I can get a confirmation on this assumption, I'm glad to open a pull request.

@sdlime
Copy link
Member

sdlime commented Dec 19, 2023

So this is for the experimental MapServer integration. I've never used that feature myself but assuming the mapfile being processed is configured in the mapcache config file and not via a request then you're correct. @tbonfort or @jbo-ads, is that assumption is correct?

--Steve

@jmckenna
Copy link
Member

@mamaar your plan sounds good to me. If you can test your change locally, confirm it works with null, and then open a pull request with that change, soon-ish, we can include it in the upcoming MapCache release. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants