About the new RateLimiting annotation

[fabiofs-br]

Hi everybody. I'm pretty interested in the new RateLimiting annotation (#250). Seems perfect in my current project, where I with to limit few specific methods with a separated bucket logic from the rest.
I added version 0.12.0 dependency and tried to configure it as described in the documentation, but didn't manage to make it work. Does require any additional configuration?
I have some doubts about it functioning too. Like, does it override other configured filters?

[MarcGiffing]

Hey, the RateLimiting annotation is independent from the filter configuration.

Annotation:
bucket4j.methods[0]
Filter:
bucket4j.filters[0]

There is still a bug as it is only works in a web application:
#260

Can you enable debug in your property and search for the Bucket4jAopConfig class. Is it enabled?

# property
debug=true

[fabiofs-br]

Yes. It's actually enabled.

Bucket4jAopConfig matched:
      - @ConditionalOnClass found required class 'org.aspectj.lang.annotation.Aspect' (OnClassCondition)
      - @ConditionalOnProperty (bucket4j.enabled) matched (OnPropertyCondition)
      - @ConditionalOnBean (types: com.giffing.bucket4j.spring.boot.starter.config.cache.SyncCacheResolver; SearchStrategy: all) found bean 'bucket4jCacheResolver' (OnBeanCondition)

Its parsing the configured expressions too, but no rate limit is applied to response of the controller.

parse-boolean-expression;result:true;expression:true;root:public org.springframework.http.ResponseEntity com.example.controller.Controller.method(java.lang.Long);params:{parameter=1}
parse-string-expression;result:1;expression:1;root:public org.springframework.http.ResponseEntity com.example.controller.Controller.method(java.lang.Long);params:{parameter=1}

I disabled the filters configuration while testing to prevent any conflict too.

Edit: After some more testing, I discover which the rate is actually been limited. Just not showing "X-Rate-Limit-Retry-After-Seconds" header in the response. Instead, it launches a RateLimitException which can be conveniently handled.

[MarcGiffing]

Yes, the headers are only added when the filters are used.
Exception Handler in Caffeine Example