-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Beta Launch #40
Comments
MatrixAI/Polykey#600 was merged incorrectly, MatrixAI/Polykey#601 is being done by @addievo to fix up the additional options of |
I finished up and merged MatrixAI/Polykey#601. Having a look over the CLI now. |
The |
The change to the
|
this is failing because we are taking we are using the falsiness of the values in the statement rather than matching
This would mean that a value of 0 for the Is this behaviour intended? If so I'll keep that as it is. |
I think you found out that 0 means infinity. |
We got about 2 weeks, so let's focus hard on getting stability and bugs fixed. |
A bunch of different issues have been thrown into this epic. We have to go over prioritisation of which is most important and delegate the tasks. Remember we got a tight timeframe here. |
Stretch 8. should be done to make sure timeouts are working.
No issue for this, but it's really part of MatrixAI/Polykey#599, and we will need that for metrics for the launch, can't launch without some metrics. |
We need to solve that MatrixAI/Polykey#598 to ensure that we don't get hit with a hug of death. We need to solve our memory leaks - all nodes connect to all testnet nodes. We need randomised round-robin for connecting to the testnet. We can do this synthetically, load test it. |
MatrixAI/Polykey#605 - regardless of how strong the strong NAT - it should work either way. |
I'm going to focus on fixing MatrixAI/js-timer#15 really quick. It's causing some minor issues across the code bases. |
Not sure how to move forward with MatrixAI/js-timer#15, It's an easy fix assuming my assumptions about how it should work is correct. But |
Timer is fixed. |
For the CLI beta launch to scale, because potentially many people may try PK and thus connect to the testnet, we need to avoid connecting to every seed node in the testnet at the same time. However this means hole punching won't work without a common seed node between source and target. To achieve this we need to revisit the decentralized hole punching problem in MatrixAI/Polykey#365 At the same time due to MatrixAI/Polykey#599 we would likely want to switch to using SRV records, so that A and AAAA records can be reserved for the testnet.polykey.com or mainnet.polykey.com dashboard. Also for the CLI beta launch to work well, we might want to deploy onto mainnet. OR default our network to testnet for now. One can even throw an error if attempting to connect to mainnet that isn't configured at all atm. We should prefer a smoother environment... so switching to just mainnet is fine. This launch will be the first version of mainnet then. |
currently Polykey agents domain do not use ctx at all, so server-side handlers will never time out. This will need to be done, and tests will need to be written with timeouts in that domain |
We get the following warning when running the CLI
@amydevs mentioned it's due to MDNS. I think we need to look into removing the warning. I don't see any issues about this however so maybe we should make a new one and look into it? It seems that MDNS is getting the handle (fd?) of the socket to modify it. I can see us needing direct access to the socket in native code for |
|
pr MatrixAI/Polykey-Docs#56 should be ready now |
I've noticed that the test |
We're getting close to completing the main stuff. @amydevs is looking into the issues with discovery we found while testing. I'm thinking I should look into making I've already made some fixes to This ties in nicely with MatrixAI/Polykey#461 since we'd need to support not having networking running for extended periods of time, but also support dynamically starting or stopping the I just did some testing with That said, there may be corner cases where the socket could just fail for one reason or another. The question is how tolerant do we want to be about this? How does this handle switching between wifi networks or interfaces? If we have two active interfaces and one starts to fail then do we seamlessly switch, or are we just tolerant of that? I suppose all theses questions will bear out with more rigorous user testing. So based on that quick test I think as things are we're fine and tolerant of network failures in that the process will no crash in these cases. I don't think there's anything to address about that right now but we should keep it in the back of our mind with further testing. |
Priorities going forward.. Discovery problemsRight now there are problems with discovery
Reviewing the repos I found the following old issues that relate to these problems.
Looks like all points are addressed across this. Some double up. Should we create a single PR addressing all of these? Seems like a decent re-work/update of discovery. All of these are on Performance problems.There are 2 performance issues.
Lingering issuesWe still need to finish up the following active issues
Moving forwardMoving forward we want to focus on any UI/UX issues and bugs we encounter during user testing. |
I'm going to make a new epic for tracking discovery problems. |
@pablo.padillo this is the main important engineering issue atm. Status update:
The work that @brian.botha and @amydevs is on right now, are all UX oriented features that help automate or reduce the amount of work for the entire demo process. This includes:
These 3 things may come after version 0.3.1. |
So upon release of 0.3.1, remove those other remaining subissues, as I consider the beta release to be done. @pablo.padillo should be redoing the demo with the understanding the more than 1 claim is fine to work with. Subsequent release of PK should be addressing the 3 items posted above. |
https://linear.app/matrix-ai/issue/ENG-298/follow-permission-and-social-links-during-discovery has been created to track point 2. above. |
@CryptoTotalWar I think upon closing this issue, we should be planning for a hard launch. You should create a new issue for that and associate subissues for a hard launch. I'm not sure if it should go into Polykey - but we could associate issues to the MatrixAI-Graph for any general work. |
NOTES Rough Draft WIP. Will clean up. Critical Issues
Needed but functional without
MatrixAI/Polykey#605 - Not super big issue, Right now it means more stricter nats can't be punched to. I have an idea for a fix. Not strictly a major error, just something we did not want to be broken. Important for reliability of usage in different network situations.
A lot of this was just fixing up bugs. "Major Feature enhancement
Features WIP
|
0.3.1 has been release a few days ago. I'm going to resolve this issue now. |
Engineering Updates Summary for Blog PostCritical Fixes
Feature Enhancements
Features in Progress (WIP)
Not Included
This summary will guide the blog post update regarding the CLI enhancements and fixes since the beta release. Please review and confirm the inclusion of these points. - @tegefaulkes |
I think that should go to your blog issue? This issue is closed. @CryptoTotalWar |
Specification
This epic focuses on the CLI beta launch targeting November 10 2023.
This follows from the 6th testnet deployment MatrixAI/Polykey#551 and focuses on any UX issues that should be resolved before we launch. Plus any documentation related things and metrics for tracking how the launch went, as well as content we need to write to prepare for it.
We should also get our demo video fully polished as well.
One of the things we need to do is:
audit
orlogs
domain to PK at first to track information about the network, we will need this as part of our metrics.testnet.polykey.com
andmainnet.polykey.com
so we can see what's going on and show everybody how the network is building up.We are currently working through this list of issues.
#40 (comment)
Additional context
Tasks
The text was updated successfully, but these errors were encountered: