Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar/Cover Image Specifications #1014

Open
Phenomephrene opened this issue Aug 11, 2024 · 9 comments
Open

Avatar/Cover Image Specifications #1014

Phenomephrene opened this issue Aug 11, 2024 · 9 comments
Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end good first issue Good for newcomers

Comments

@Phenomephrene
Copy link

QoL/UX Improvement Request:

If possible, on user settings/profile page include supported file types and image size requirements next to or near the area to change Avatar and Cover images. This may reduce any frustration in trying to upload appropriate images, and increase feature adoption.

Thanks for considering.

@Phenomephrene Phenomephrene added the enhancement New feature or request label Aug 11, 2024
@ghost
Copy link

ghost commented Aug 11, 2024

While I agree this is a necessary enhancement, please use the templates when submitting issues so we can deduce if there's a problem with a specific release and/or instance running said release. That said, there's a high priority bug that's impacting images in the latest tagged 1.7.1-rc1 release of Mbin and your instance could be impacted if they are not running the latest code from the main branch. #1011

@ghost ghost added the more information needed requires more info to solve label Aug 11, 2024
@Phenomephrene
Copy link
Author

Phenomephrene commented Aug 11, 2024

Sorry about that. I'm new to github, and probably one of the less tech savvy fediverse users you're likely to come across.

My home instance is thebrainbin.org which says it is currently running mbin version 1.7.1-rc1

For what it's worth, the current behavior exactly mirrors the types of issues I was having when based out of kbin.social. Attempting different formats (e.g. jpegs, pngs) of various different file sizes, where even trying to match format and image size of images that have previously worked won't necessarily guarantee that a new image will successfully update. I figured it was still something I was doing incorrectly since, like I said, I'm not the most tech savvy person.

If this is due to the known bug or not, clarifying what file type/size should work seemed maybe an easy addition (?) and is useful info to make on-boarding new members a bit friendlier.

Thanks again.

@ghost
Copy link

ghost commented Aug 11, 2024

Sorry about that. I'm new to github, and probably one of the less tech savvy fediverse users you're likely to come across.

My home instance is thebrainbin.org which says it is currently running mbin version 1.7.1-rc1

For what it's worth, the current behavior exactly mirrors the types of issues I was having when based out of kbin.social. Attempting different formats (e.g. jpegs, pngs) of various different file sizes, where even trying to match format and image size of images that have previously worked won't necessarily guarantee that a new image will successfully update. I figured it was still something I was doing incorrectly since, like I said, I'm not the most tech savvy person.

If this is due to the known bug or not, clarifying what file type/size should work seemed maybe an easy addition (?) and is useful info to make on-boarding new members a bit friendlier.

Thanks again.

sounds good, and thanks for clarifying! i believe @BentiGorlich has thebrainbin.org updated to include the fix, so probably not related :-)

@ghost ghost added frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end good first issue Good for newcomers and removed more information needed requires more info to solve labels Aug 11, 2024
@BentiGorlich
Copy link
Member

Yeah thebrainbin only runs on releases. Thats what I decided. Though I can make an exception for this one and just pull main, so image uploads can work again, though I think just setting the env var for max kmage size already fixes it right? It just defaults to 0 bytes max size

@ghost
Copy link

ghost commented Aug 11, 2024

Yeah thebrainbin only runs on releases. Thats what I decided. Though I can make an exception for this one and just pull main, so image uploads can work again, though I think just setting the env var for max kmage size already fixes it right? It just defaults to 0 bytes max size

the bug causes the default to not load correctly, so that's fair if you had it set to something in the .env... i think.

@BentiGorlich
Copy link
Member

I updated thebrainbin, so your problems with image uploads should be fixed. However I agree that the max image size should be communicated in the UI

@Phenomephrene
Copy link
Author

Great! Successful upload on my end. I appreciate your effort! Thanks.

@BentiGorlich
Copy link
Member

No problem :)

@BentiGorlich
Copy link
Member

I think this one is done with #1019
or do you think the supported formats are necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants