Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of toggle buttons #20

Open
splendido opened this issue May 22, 2015 · 5 comments
Open

Refactor of toggle buttons #20

splendido opened this issue May 22, 2015 · 5 comments

Comments

@splendido
Copy link
Member

I'm thinking to start a refactor of the code to end up showing three different toggle buttons.

  1. enable auto-publish (for repositories containing a Meteor package)
  2. simple webhook creation (for 3rd party library we're going to wrap)
  3. enable auto-publish for repo with wrapped packages (which is: repository being under MeteorPackages and including a autopublish.json file..)
@dandv
Copy link
Contributor

dandv commented May 22, 2015

Button #1 seems like an easy convenience, right? It would only save authors from running meteor publish after git push, if I understand correctly.

For #3, did you mean "repo with wrapped package_s_", i.e. multiple packages?

@splendido
Copy link
Member Author

yeah, n.1 would be for private packages (would we really like to support this?)
n.3 would be for our repositories wrapping 3rd party libraries like snapsvg-wrapper to cite the latest one...

@zimme
Copy link
Member

zimme commented Jun 1, 2015

I use autopublish for all my packages, but I guess I could do manual meteor publish whenever I release

@splendido
Copy link
Member Author

@zimme it's fine you use autopublish!
...you're giving a bunch of valuable feedbacks this way, so please do use it.

The question:

would we really like to support this?

is more for the long term, just in case too many people started to use it for private packages.

I already have a list of hooks with their own approval status, but I'm actually ignoring it when receiving triggers...
We might think to really consider approvals... but this would mean having someone taking care of new subscription requests, which means time...
...perhaps in case MDG will show some more interest on this ;-)

Btw, I've just turned users @zimme and @dandv admin users so you can view some more button... :-)

@zimme
Copy link
Member

zimme commented Jun 1, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants