Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent data type values in annotations.json #26

Open
ehinderer opened this issue Nov 13, 2018 · 1 comment
Open

Inconsistent data type values in annotations.json #26

ehinderer opened this issue Nov 13, 2018 · 1 comment

Comments

@ehinderer
Copy link
Member

This may be a minor issue, but in circumstances where there is a single gene associated with an annotation under the "annotation_features" key in annotatinos.json, the value associated with each key in the nested dictionary is a string, rather than a list of length 1 with a single string. All other instances are a list of strings. I'm not sure if this is necessary or an intentional design decision but it was giving me some problems when I was looking up associated genes in enrichment results. I think the only reason those annotations were enriched in the first place is because there were very few genes of interest from a very large set of genes.

@rmflight
Copy link
Member

More than likely, this is due to using the default parameters of jsonlite::toJSON() on the annotation object, where b/c it is length one, it doesn't create a list. I'll have to look into it and see how to make sure we have consistent behavior regardless of the length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants