-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change profile languages #39
Comments
German
English (American)
English (British)
Spanish
French
Italian
Dutch -- (may need to skip this due to low translation progress)
Polish
Portuguese (Brasil) -- (may need to skip this due to low translation progress)
Portuguese (Europe) -- (may need to skip this due to low translation progress)
Russian
Suomeksi -- (may need to skip this due to low translation progress)
Turkish -- (may need to skip this due to low translation progress)
Greek -- (may need to skip this due to low translation progress)
Chinese (traditional)
Chinese (modern)
|
Not sure if all languages are even necessary or probably only 2-3 to make sure this feature works in general. |
In general 2-3 would be fine, but actually checking all of them would be good for another reason - to make sure translations come up right |
"Polnish" --> "Polish" !
Actually there is not need to close and restart Mudlet to check this as the "Profile preferences" dialogue is wired up to change pretty much it's entire content completely (IIRC) on locale changes - without the need for a restart... |
Feedback 1 and 2 applied.
|
It's like this - while the preferences window does indeed change texts' language immediately, other Mudlet windows do still show the earlier translation instead. |
I think just a few places is enough - to balance the amount of work to do vs the chances of it breaking something important. |
Since we now do change the command line output for the Furthermore, there are currently two sources of translated texts (for the GUI application case) - Mudlet's own and Qt's built-in (for it's own dialogues) we, perhaps, need to verify both - otherwise we would not have missed Mudlet/Mudlet#6604 ! |
Need a test to make sure this crash does not occur anymore
Mudlet/Mudlet#5752
The text was updated successfully, but these errors were encountered: