Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change profile languages #39

Open
Kebap opened this issue Dec 12, 2021 · 8 comments
Open

Change profile languages #39

Kebap opened this issue Dec 12, 2021 · 8 comments
Labels
feature-profile-preferences Test using the Preferences dialog

Comments

@Kebap
Copy link

Kebap commented Dec 12, 2021

Need a test to make sure this crash does not occur anymore
Mudlet/Mudlet#5752

@Kebap Kebap added the feature-profile-preferences Test using the Preferences dialog label Dec 16, 2021
@Kebap Kebap changed the title Fix shortcuts crash Change profile languages Dec 16, 2021
@Kebap
Copy link
Author

Kebap commented Dec 16, 2021

German

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

English (American)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

English (British)

  • open preferences popup, General tab, change language to
  • close and restart Mudlet, assert menus / buttons show new language like so: open preferences popup, check text for the 5th tab contains the word "Colour view" rather than "Color view"

Spanish

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

French

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Italian

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Dutch -- (may need to skip this due to low translation progress)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Polish

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Portuguese (Brasil) -- (may need to skip this due to low translation progress)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Portuguese (Europe) -- (may need to skip this due to low translation progress)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Russian

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Suomeksi -- (may need to skip this due to low translation progress)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Turkish -- (may need to skip this due to low translation progress)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Greek -- (may need to skip this due to low translation progress)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Chinese (traditional)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

Chinese (modern)

  • open preferences popup, General tab, change language
  • close and restart Mudlet, assert menus / buttons show new language

@Kebap
Copy link
Author

Kebap commented Dec 16, 2021

Not sure if all languages are even necessary or probably only 2-3 to make sure this feature works in general.

@vadi2
Copy link
Member

vadi2 commented Dec 16, 2021

In general 2-3 would be fine, but actually checking all of them would be good for another reason - to make sure translations come up right

@SlySven
Copy link
Member

SlySven commented Dec 28, 2021

"Polnish" --> "Polish" !

English (British)

open preferences popup, General tab, change language to
close and restart Mudlet, assert menus / buttons show new language -- may need to dig deeper to find actual differences

open preferences popup, check text for the 5th tab contains the word "Colour view" rather than "Color view"

Actually there is not need to close and restart Mudlet to check this as the "Profile preferences" dialogue is wired up to change pretty much it's entire content completely (IIRC) on locale changes - without the need for a restart...

@Kebap
Copy link
Author

Kebap commented Dec 29, 2021

Feedback 1 and 2 applied.

  • Need to verify 3 first.

@Kebap
Copy link
Author

Kebap commented Jan 25, 2022

It's like this - while the preferences window does indeed change texts' language immediately, other Mudlet windows do still show the earlier translation instead.
We need to decide actually how many and at which places do we want to review the strings shown exactly?
My initial assumption was, just check the main window and the buttons/menu texts. Only for British there was no obvious difference, so I specified the preferences window instead (as one of the few places where those actually do differ) - but maybe we should look at translations in other popups and functionality as well? 🤔

@vadi2
Copy link
Member

vadi2 commented Jan 25, 2022

I think just a few places is enough - to balance the amount of work to do vs the chances of it breaking something important.

@SlySven
Copy link
Member

SlySven commented Mar 23, 2023

Since we now do change the command line output for the --help and --version arguments - and that system of translations is done differently (because we are not then running a GUI application) we ought to check that as well.

Furthermore, there are currently two sources of translated texts (for the GUI application case) - Mudlet's own and Qt's built-in (for it's own dialogues) we, perhaps, need to verify both - otherwise we would not have missed Mudlet/Mudlet#6604 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-profile-preferences Test using the Preferences dialog
Projects
None yet
Development

No branches or pull requests

3 participants