[Bug]: Opening Settings on a Layer turns that layer on

[cirquelar]

Checked for duplicates

Yes - I've already checked

Describe the bug

I wanted to search for a feature in a layer before that layer was turned on. When I clicked the settings button, the layer turned on automatically. This was with a geodataset source. I'm guessing that loading the layer is done to auto-populate the propery field and allow the value field to be searchable. On a large dataset, this is problematic. Also, I wouldn't expect this to occur with a geodataset.

What did you expect?

I expected a search to be conducted without turning the layer on.

Reproducible steps

1. Add a geodataset
2. make a layer pointing to the geodataset, but leave Visibility off.
3. Open the Layer tool and click on the Settings icon.

Environment

- Version of this software: 2.11
- Operating System: Windows 11