Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to read data: Warning invalid value encountered in multiply data_curves #180

Open
ELGarulli opened this issue Mar 19, 2024 · 4 comments

Comments

@ELGarulli
Copy link

Dear Ephyviewer community,

First of all thank you so much for your work, having this simple tool is an amazing help. Today I tried to share the joy of using ephyviewer with a colleague (@dsr33) but we encountered what seems to be a bug.
We tried to visualize data from numpy arrays. The same file works on my computer and displays correctly (jupyter notebook Python 3.8.8)
MicrosoftTeams-image

However, when trying to run the same code, on the same data on my colleague's computer the data appears clipped and generally wrong.
MicrosoftTeams-image (1)

On his computer we tested the code in jupyter notebook, spyder (Python 3.11.5) and Pycharm (Python 12), and obtained the same result. We both have the same ephyviewer version (1.6). The only warning raised is the following:

ephyviewer\Lib\site-packages\ephyviewer\traceviewer.py:332: RuntimeWarning: invalid value encountered in multiply data_curves *= total_gains[visibles, None]

We could reproduce the same error also with the simple example you provided. When we inspected how "data_curves" looks like at the line that throws the warning, we saw that it contained a nan value. If I understand this correctly, this shouldn't be there as the data in the example are randomly generated.

Could I ask you for your support in resolving this? Please let me know if I can provide any additional information.

@samuelgarcia
Copy link
Collaborator

Hi,
thanks for the kind words.
Can you try with installing from source ?
If you have the same I will try to have a look. I get recently strange behavior on a computer of a colleague too!

@ELGarulli
Copy link
Author

Hi!
Thanks for the super quick reply, we will try tomorrow.
As a small update, it looks like changing the time width in the GUI makes it or breaks it.
Here is time width 1s

MicrosoftTeams-image (2)

Here is at 0.05

MicrosoftTeams-image (3)

On these data it looks like the tipping point is 0.5s

@samuelgarcia
Copy link
Collaborator

Hi.
I am able to reproduce this on the pypi version 1.6.0 but seems to be fixed in the source.
I aill make a release next monday.

@ELGarulli
Copy link
Author

Hi,
thanks a lot, sorry I didn't get to test the source yet.
But that's fantastic news. Again thanks for your super quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants