Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a policy for deprecating IOs #1460

Open
zm711 opened this issue Apr 13, 2024 · 2 comments
Open

Make a policy for deprecating IOs #1460

zm711 opened this issue Apr 13, 2024 · 2 comments
Milestone

Comments

@zm711
Copy link
Contributor

zm711 commented Apr 13, 2024

KwikIO for the Kwik format of stuff constantly throws warnings (I believe it is meant for python < 3.7). We should have a policy for either removing from tests or removing from the code base if something is unsupportable. Some of these warnings will become hard errors soon.

If we remove from tests we warn the user that it requires old versions of python that must be installed etc at the users own risk

If we remove the io completely maybe have a warning that says this io has been removed and if needed the user should use an old version of neo?

@zm711 zm711 added this to the 0.14.0 milestone May 3, 2024
@zm711
Copy link
Contributor Author

zm711 commented May 3, 2024

Policy discussed was that:

  1. Removal of IO once there are no versions of python/numpy which can support the IO + add class with warning explaining to downgrade to an earlier version of Neo
  2. add warning to IO if the python/numpy version is limited to let the user know they need to pick a different version

@h-mayorquin
Copy link
Contributor

This makes sense. I will also ease development burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants