Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1530 [IgorIO and missing "xUnits"] #1531

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Fix for #1530 [IgorIO and missing "xUnits"] #1531

merged 3 commits into from
Oct 11, 2024

Conversation

apdavison
Copy link
Member

"xUnits" is only used in Versions 1, 2, 3 of .pxp files; Version 5 uses "dimUnits" - see https://github.com/AFM-analysis/igor2/blob/43fccf51714661fb96372e8119c59e17ce01f683/igor2/binarywave.py#L501

@apdavison
Fix for NeuralEnsemble#1530
318e4ef 
"xUnits" is only used in Versions 1, 2, 3 of .pxp files; Version 5 uses "dimUnits" - see https://github.com/AFM-analysis/igor2/blob/43fccf51714661fb96372e8119c59e17ce01f683/igor2/binarywave.py#L501
@apdavison apdavison linked an issue Aug 27, 2024 that may be closed by this pull request
[IgorIO] Not all .pxp files have "xUnits" in the header #1530
Closed
@apdavison apdavison added the IO label Aug 27, 2024
@apdavison apdavison added this to the 0.14.0 milestone Aug 27, 2024
@apdavison apdavison requested a review from zm711 August 27, 2024 13:47
zm711
zm711 previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine as long as tests pass. Do we have a test file for this we could add to GIN? I'm happy to do it if you can share with me :)

@apdavison
Copy link
Member Author

The files I have are around 70 MB, which is probably too big for a test file, no?

@zm711
Copy link
Contributor

zm711 commented Aug 27, 2024

Yeah, the goal is < 10 MB. We are currently checking with @JuliaSprenger if a couple 20MB files are okay. Okay, I mean it would be better to have test files.

Could we maybe add a comment by the if-elif-else block saying that this header info is confirmed by you and that if other file formats appear that we will address those later; currently need testing files. Or something of that nature?

@zm711 zm711 merged commit 293f35a into NeuralEnsemble:master Oct 11, 2024
3 checks passed
@zm711 zm711 modified the milestones: 0.14.0, 0.13.4 Oct 12, 2024
@apdavison apdavison deleted the issue1530 branch October 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zm711 zm711 zm711 approved these changes

Assignees
No one assigned
Labels
IO
Projects
None yet
Milestone
0.13.4
Development

Successfully merging this pull request may close these issues.

[IgorIO] Not all .pxp files have "xUnits" in the header
2 participants
@apdavison @zm711