From a8f72db864ce4cde94749760f21ac804acc832bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 22 Jul 2024 08:52:12 +0200 Subject: [PATCH 1/2] Rename Nixpkgs committer delegation team -> Nixpkgs committer admins Without explanation it's not clear to me what this team actually does. Hopefully this gives us a better idea. --- doc/github.md | 2 +- doc/nixpkgs-committers.md | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/github.md b/doc/github.md index 6d34059..198ade3 100644 --- a/doc/github.md +++ b/doc/github.md @@ -14,7 +14,7 @@ There are many repositories, but these are some of the most important ones. The Nix package collection and NixOS. -Currently there is an interim process for managing commit access, which is done by the Nixpkgs committer delegation team, whose processes are described [here](./nixpkgs-committers.md) and consists of these people: +Currently there is an interim process for managing commit access, which is done by the Nixpkgs committer admins, whose processes are described [here](./nixpkgs-committers.md) and consists of these people: - @Mic92 - @NickCao - @jtojnar diff --git a/doc/nixpkgs-committers.md b/doc/nixpkgs-committers.md index 2638bcb..6f98380 100644 --- a/doc/nixpkgs-committers.md +++ b/doc/nixpkgs-committers.md @@ -3,9 +3,9 @@ There are over 200 Nixpkgs committers with access to merge any PR. To become a Nixpkgs committer, you can apply [in this issue](https://github.com/NixOS/nixpkgs/issues/321665). -The [Nixpkgs committer delegation team](./github.md#nixpkgs) is given the responsibility and authority of changing the list of [Nixpkgs committers](https://github.com/orgs/NixOS/teams/nixpkgs-committers). +The [Nixpkgs committer admins](./github.md#nixpkgs) is given the responsibility and authority of changing the list of [Nixpkgs committers](https://github.com/orgs/NixOS/teams/nixpkgs-committers). ## Process - The process must be publicly documented (this document) -- Any change to the process must be unanimously agreed upon by all delegation team members -- Any change in the list of committers must be publicly documented and agreed upon by all delegation team members +- Any change to the process must be unanimously agreed upon by all Nixpkgs committer admins. +- Any change in the list of committers must be publicly documented and agreed upon by all Nixpkgs committer admins. From 6630035bbe6e06aa29c52d37d9de11cc9e52baf6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Thalheim?= Date: Mon, 22 Jul 2024 09:52:15 +0200 Subject: [PATCH 2/2] move nixpkgs applications to a seperate repository --- doc/nixpkgs-committers.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/doc/nixpkgs-committers.md b/doc/nixpkgs-committers.md index 6f98380..04b2065 100644 --- a/doc/nixpkgs-committers.md +++ b/doc/nixpkgs-committers.md @@ -1,11 +1,15 @@ # Nixpkgs committers There are over 200 Nixpkgs committers with access to merge any PR. -To become a Nixpkgs committer, you can apply [in this issue](https://github.com/NixOS/nixpkgs/issues/321665). + +To become a Nixpkgs committer, you can apply by creating an issue [here](https://github.com/Mic92/nixpkgs-committers/issues/new/choose). (TODO: move this repository) +Committers should have their GitHub name/ID in the [maintainer-list](https://github.com/NixOS/nixpkgs/blob/master/maintainers/maintainer-list.nix). +This allows us to keep track of committers even if usernames are changed or accounts are deleted. The [Nixpkgs committer admins](./github.md#nixpkgs) is given the responsibility and authority of changing the list of [Nixpkgs committers](https://github.com/orgs/NixOS/teams/nixpkgs-committers). -## Process +## Rules for changing the process for managing nixpkgs committer access + - The process must be publicly documented (this document) - Any change to the process must be unanimously agreed upon by all Nixpkgs committer admins. - Any change in the list of committers must be publicly documented and agreed upon by all Nixpkgs committer admins.