-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll out Slang features in the VS Code extension for users #639
Comments
Some more contexts on catching the rogue Rust panics in the TS LSP server: We expose our Rust code using Panicking in Rust is tricky. There are two strategies: Since we're loaded into a C++ code and there's no built-in Rust panic/C++ exception interop, we'd need to unwind ourselves and propagate a C++ exception up, but this means more manual There is One option is to use the custom panic hook and log every Rust panic to a report file and then handle those on abrupt LSP connection loss on the extension side, but in 99% of the time we hopefully will already catch any Rust panics via the As such, I don't think there's much value in doing that; if we get error reports about very rare/mysterious crashes I'd be open to revisiting it at some point but the scenario discussed seems all too theoretical for now. We're probably better off writing a |
Split the remaining work into smaller tasks. Closing this since all other work items are completed. |
…nknown-linux-gnu` (#909) Required for NomicFoundation/hardhat-vscode#546 #639 Without this, we host-compiled our native addon with the GLIBC of the runner (`ubuntu-22.04`), which is 2.33. That's too high and will cause linking issues on older, stable distributions such as Debian 11 (2.31), Debian 10 (2.28), Ubuntu 20.04 (2.31) etc. The Linux requirement for VS Code atm is 2.28 (https://code.visualstudio.com/docs/supporting/requirements#_additional-linux-requirements) and was bumped in [1.86](https://code.visualstudio.com/updates/v1_86). Prior to that, the required version was 2.17 and we might consider targeting it instead, until we bump the required VS Code engine for the shipped extension (cc @kanej). Here is the latest runs that check that the `infra publish npm --dry-run` executes as expected and passes the relevant checks on our CI: https://github.com/Xanewok/slang/actions/runs/8472800732/job/23215682564. The built artifacts are uploaded as part of the pipeline so they can be additionally downloaded and inspected manually for the GLIBC symbols.
Blocking Changes
#[napi(catch_unwind)]
everywhere #706).Gradual Release
Other Important Optimizations
The text was updated successfully, but these errors were encountered: