Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RMA SO wizard quantity default to 0 and show max #406

Open
jbaudoux opened this issue Jul 4, 2024 · 4 comments · May be fixed by #407
Open

RMA SO wizard quantity default to 0 and show max #406

jbaudoux opened this issue Jul 4, 2024 · 4 comments · May be fixed by #407
Labels
enhancement

Comments

@jbaudoux
Copy link

jbaudoux commented Jul 4, 2024

When creating an RMA from an SO, it currently opens a wizard with all lines of the SO with the quantity preset to the SO delivered quantity (in fact returnable delivered quantity).

I have several customers that are managing large SOs and facing an RMA for one or few lines. This requires to delete all extra lines or set the quantity to 0 which is cumbersome.
In this case, what would be convenient is to have the quantity by default to 0 and have another column showing the max quantity that can be returned.

I can understand this change of approach may not be convenient to current users. Should this change be implemented in another module like rma_sale_show_max_qty or should this be a configuration option in the base rma_sale module?
@chienandalu
Copy link
Member

That's how the portal works by default. Maybe both approaches (backend wizards/portal frontend) may converge...

@pedrobaeza
Copy link
Member

What about adding buttons in the wizard to "Select all" and "Unselect all"?

@sbejaoui
Copy link
Contributor

What about adding buttons in the wizard to "Select all" and "Unselect all"?

+1

To combine both ideas, we can add another column, "allowed quantity," which will contain the maximum quantity we can return with two buttons at the top of the tree:

  1. Select all: copy the maximum quantity into the quantity field
  2. Unselect all: set the quantity field to 0 for all lines

We may also need a check to ensure that the quantity is always less than or equal to the maximum quantity.

@jbaudoux
Copy link
Author

@sbejaoui Sounds good. I would add a checkbox Select all instead of buttons as we are in a popup. If there is only one line, then it can be active, otherwise I would make it inactive by default.
I would then do this change directly in rma_sale

@sbejaoui sbejaoui linked a pull request Jul 12, 2024 that will close this issue
Open
@rousseldenis rousseldenis linked a pull request Jul 12, 2024 that will close this issue
[16.0][IMP] rma_sale: Display the allowed quantity to return in the RMA wizard #407
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[16.0][IMP] rma_sale: Display the allowed quantity to return in the RMA wizard acsone/rma
4 participants
@chienandalu @pedrobaeza @jbaudoux @sbejaoui