[17.0] mail_tracking starting endless email loop

[Bart-dh]

module: mail_tracking
version: 17.0 EE
Odoo.sh hosting

• Case: custom domain and custom alias domain, e.g. 'test.com'
• web.base.url set to 'test.com' and web.base.url.freeze param set
• alias domain is 'test.com'
• catchall address is '[email protected]'

For some reason unknown to me, at some point when sending an email, [email protected] gets added as recipient, resulting in the sent mail returning to Odoo immediately, and starting an endless email loop. A client of ours sent 21k emails this weekend to a supplier because of this loop.

Note that the reply-to is [email protected] instead of [email protected], so I don't know where the default catchall comes from. I have noticed that the module also adds extra suggested recipients though, so maybe this is related.

I have no proof that this module caused the issue, other than it started after installation, and does not happen anymore after deinstallation.

[Bart-dh]

@chienandalu

[chienandalu]

Hi, @Bart-dh

It could be that the original mail had that [email protected] in the extra recipients, which are added to the suggested recipients for the message replies:

social/mail_tracking/models/mail_thread.py

Lines 65 to 73 in 27f3809

	def _message_get_suggested_recipients(self):
	"""Adds email 'extra' recipients as suggested recipients.
	If the recipient has a res.partner, use it.
	"""
	res = super()._message_get_suggested_recipients()
	self._add_extra_recipients_suggestions(res, "email_cc", _("Cc"))
	self._add_extra_recipients_suggestions(res, "email_to", _("Anon. To"))
	return res

We try to dectect the existing aliases:

social/mail_tracking/models/mail_thread.py

Line 77 in 27f3809

aliases = self.env["mail.alias"].get_aliases()

In order to discard them

social/mail_tracking/models/mail_thread.py

Lines 90 to 94 in 27f3809

	if not partner_id:
	if email not in aliases:
	self._message_add_suggested_recipient(
	suggestions, email=email, reason=reason
	)

This is where we retrieve them (in v17 there's a new way to set the catchall with the mail.alias.domain records that allow multi-domain catchalls):

social/mail_tracking/models/mail_alias.py

Lines 10 to 23 in 27f3809

	@api.model
	@tools.ormcache()
	def get_aliases(self):
	"""We want to discard these addresses for trackings"""
	aliases = {
	x["display_name"]
	for x in self.search_read([("alias_name", "!=", False)], ["display_name"])
	}
	mail_alias_domain = self.env["mail.alias.domain"].search([])
	catchall_emails = set(mail_alias_domain.mapped("catchall_email"))
	default_from_emails = set(
	mail_alias_domain.filtered("default_from").mapped("default_from_email")
	)
	return aliases | catchall_emails | default_from_emails

Also check if a partner could have that catchall email set, as it could be that is assigning it directly:

social/mail_tracking/models/mail_thread.py

Lines 85 to 86 in 27f3809

	partners_info = self.sudo()._message_partner_info_from_emails(email_extra_list)
	for pinfo in partners_info:

[Bart-dh]

@chienandalu what is the reason for adding extra suggested recipients? To me it looks like extra functionality which is irrelevant to the rest of this module, but I could be mistaken

[pedrobaeza]

It's inside the scope, as Odoo is not considering CC unless a contact matching the email address exists, and this module does it.