Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall functional testing / result documentation #8

Open
OSevangelist opened this issue Feb 26, 2022 · 2 comments
Open

Overall functional testing / result documentation #8

OSevangelist opened this issue Feb 26, 2022 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right question Further information is requested

Comments

@OSevangelist
Copy link

OSevangelist commented Feb 26, 2022

Conducted Tests

Test scope: Functional
Test conduct: Manual user testing
Test coverage: All available modules of the v12 repository in conjunction
Test instance: V12 on Runboat

Questions

  • It is not clear what the "lock" feature is for?
  • It is not clear if a rentable product always needs to be of a product type "service" linked to a "storable product" or is a storable product itself, If one tries to link a service to a storable product it complaints about "the rental product 'XYZ' must have the option 'Must Have Start and End Dates' checked." but its not clear where to check this

Potential enhancements

  • Panel "Rental Price" should be a list and make use of the UoM functions
  • 'Interval basis' should probably make use of the 'date range' OCA model

Functional issues

  • Even though i have a quantity at hand of 1 for a storable product, a rental quotation is still complaining that i has no sufficient stock when trying to do a rental quotation. This make testing the entire flow impossible
@OSevangelist OSevangelist added the bug Something isn't working label Feb 26, 2022
@OSevangelist OSevangelist changed the title Overal functional testing Overall functional testing of vertical rental v12 Feb 26, 2022
@OSevangelist OSevangelist added documentation Improvements or additions to documentation invalid This doesn't seem right question Further information is requested and removed bug Something isn't working labels Feb 26, 2022
@OSevangelist
Copy link
Author

Hi @marylla @olaf-wagner @benbrich i have provided my test results here. I also tested v14 but i prefer to document the features and meanings for the originating version 12 first before also sharing v14 results, if you agree

@OSevangelist OSevangelist changed the title Overall functional testing of vertical rental v12 Overall functional testing Feb 26, 2022
@OSevangelist OSevangelist changed the title Overall functional testing Overall functional testing / result documentation Feb 26, 2022
@marylla
Copy link

marylla commented Feb 28, 2022

@OSevangelist

Answers to your questions:

  1. What do you mean with "lock" feature? Where did you see this? Doesn't ring a bell...
  2. A rentable product ist always a storable product, and then you create the related rental service. This is actually the standard behavior or sale_rental. The "must have start and end date" has to be set for the rental service (if I am not wrong you find this boolean field in accounting page of products, also comes from an OCA module)

Comments to your enhancements:

  1. What do you mean "use uom functions"? And how do you want to make it a list? Then, how do you want to visually group the features for monthly, daily or hourly features? In addition to the bulk prices we plan to publish a feature to define insurances for each rental service that will generate additional sale order lines in rental orders. These information are also specific to the rental services that you activate by the boolean fields. But maybe I just misunderstood your suggestion?
  2. That is a probably a good question for @benbrich because he uses this feature already in production.

Functional Issues:

  1. Was your quantity on hand on the "rental in" location? That is the standard behavior of sale_rental. If it is on WH/Stock, it is not "released" for rental. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants