Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only export keyframes for node animations #87

Open
1 task
paroj opened this issue Apr 20, 2021 · 6 comments
Open
1 task

only export keyframes for node animations #87

paroj opened this issue Apr 20, 2021 · 6 comments

Comments

@paroj
Copy link
Member

paroj commented Apr 20, 2021

This function processess the objects animation frame by frame, insted of using its keyframes

Im not fully happy with this. While I understand the need of it, there are serious drawbacks.

  • what are the FPS of the animation? 24 as the blender default? This might or might not do what the user expects.
  • by getting rid of the keyframes, there are no keyframes to easily modify the animation in code
  • unrolling the animation in .skeleton is less evil as that is a binary format not edited by humans. .scenes on the other hand seem to be designed to be human readable. But with unrolling animations you end with something like this:
    vrar20-3dvis

I think in this case, I would just for once advocate for a user-switch (default-off):

  • only write node keyframes

(we can also merge this as is and add that later)

Originally posted by @paroj in #86 (comment)

@oldmanauz
Copy link
Contributor

The code for this feature exists, it's commented out though.
Was it disabled for a reason?
Do you want it re-enabled?

@paroj
Copy link
Member Author

paroj commented Sep 30, 2021

Was it disabled for a reason?

yes, see: #86 (comment)

@sercero
Copy link
Collaborator

sercero commented Sep 30, 2021

@oldmanauz I was the one who implemented this feature.

I was unable to come up with a solution on how to export the keyframes, it didn't seem as simple as exporting every frame.

@oldmanauz
Copy link
Contributor

@sercero I see your logic. Is it better to have a well documented part-implementation that might suit some than potentially never having a solution?

@paroj
Copy link
Member Author

paroj commented Sep 30, 2021

I would prefer having that part implementation

@sercero
Copy link
Collaborator

sercero commented Oct 2, 2021

@oldmanauz, @paroj: of course I have no problem with more options, mostly my concern is that the option to export every keyframe is still present.

Also, I acknowledge that there are cases when exporting only the keyframes is enough, so it is useful of course to have that option as well.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants