Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some payloads coming from Atomic Red team are marked as "Manual" #46

Open
SamuelHassine opened this issue Oct 17, 2024 · 5 comments
Open
Assignees
Labels
bug use for describing something not working as expected
Milestone

Comments

@SamuelHassine
Copy link
Member

Description

image

https://filigran.obas.filigran.io/admin/payloads

Should be "community"

@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Oct 17, 2024
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Oct 28, 2024
@EllynBsc EllynBsc added this to the Release 1.9.0 milestone Oct 28, 2024
@savacano28 savacano28 self-assigned this Oct 28, 2024
@savacano28 savacano28 removed their assignment Oct 29, 2024
@johanah29
Copy link
Member

Hello @EllynBsc and @jborozco
After investigation, it turns out that the payloads mentionned earlier do no longer exist in the atomic red team folder. We now need to figure out what we should when such an event happens. We have three options:

  • Delete the payload from the database
  • Keep the payload with a "deprecated" or "no longer exist" flag
  • Keep things unchanged

@johanah29 johanah29 added the needs more info use to identify issue needing additional info to be triaged or solved label Oct 31, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Oct 31, 2024

Hi @johanah29 👋

2 solutions here IMO:

👉 Solution 1: Keep the payload with a "deprecated in version XX" flag, i think it's important to state to our user that it's deprecated in the current repo version of Atomic Red Team we're using but it might not be the case in a previous version.

👉 Solution 2: Delete the payload from the database, IMO it's not useful for the user to end up on a payload that does not exist in the atomic red team folder. And we should also specify what version of Atomic red team we're using.

=> I'd say we go for solution 1 for now, and then if we realize that atomic red team updates a lot and we end up with a ton of payloads deprecated then we can put solution 2 in place. WDYT ?

@jborozco
Copy link

jborozco commented Nov 4, 2024

@johanah29 @EllynBsc Hello, I would say let's delete the payload to make sure our offer is reflecting functioning payloads.

@jborozco jborozco removed the needs more info use to identify issue needing additional info to be triaged or solved label Nov 4, 2024
@EllynBsc
Copy link
Member

EllynBsc commented Nov 4, 2024

Hi @jborozco 👋

Good for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected
Projects
None yet
Development

No branches or pull requests

6 participants