Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zerofox] Title indicator and country structure to be corrected #2828

Open
NiQuintin opened this issue Oct 22, 2024 · 4 comments
Open

[Zerofox] Title indicator and country structure to be corrected #2828

NiQuintin opened this issue Oct 22, 2024 · 4 comments
Labels
bug use for describing something not working as expected partner support use to identify an issue related to feature developed & maintained by the third-party vendor.
Milestone

Comments

@NiQuintin
Copy link

Description

In the latest version of the connector, two small corrections need to be made:

  • Remove "Pattern for malware" from the title, leaving only the hash in the title.
  • For the country entities, apply a correction so that they display correctly (see screenshots).

Screenshots (optional)

image
image

@NiQuintin NiQuintin added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Oct 22, 2024
@NiQuintin
Copy link
Author

@DNRRomero last little fix to make. If you have questions do not hesitate.

cc: @helene-nguyen

@romain-filigran romain-filigran added community support use to identify an issue related to feature developed & maintained by community. partner support use to identify an issue related to feature developed & maintained by the third-party vendor. and removed needs triage use to identify issue needing triage from Filigran Product team community support use to identify an issue related to feature developed & maintained by community. labels Oct 23, 2024
@alexmfarrell
Copy link

Hey there! I understood the original ask from was to not have the hash being the sole title of the entry, as asked here (#2780)? You want this reverted back, and just show the hash?
2nd point, you just want the country code, eg "TW" and not "TW-400"?
Given these are just cosmetic issues and not functional errors we will have to prioritise this update into our backlog to join other items to be planned. These update should not be affecting the flow of data to the end customer.

@NiQuintin
Copy link
Author

Hey @alexmfarrell thanks for your feedback 😊

Yes usually we just add the hash in title like this:

image

For the countries, the best would be to add the full name of the country or at least just the country code like "TW".

Oh and just seen also for the Indicators, you need to fill in the field x_opencti_main_observable_type otherwise it's gonna be impossible for users to filter on them:

image

Screenshot 2024-10-21 100701

@helene-nguyen helene-nguyen added this to the Bugs backlog milestone Oct 24, 2024
@alexmfarrell
Copy link

@NiQuintin Cool, this has been prioritised into our backlog. Will let you know when the PR is ready. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected partner support use to identify an issue related to feature developed & maintained by the third-party vendor.
Projects
None yet
Development

No branches or pull requests

4 participants