Have only one variant of expectEvent

[frangio]

Our expectEvent helper currently comes in two variants: expectEvent.inLogs and expectEvent.inTransaction. As far as I can tell, we only need one of the two. inTransaction was suggested by @nventuro as the one to keep.

I'd also reconsider whether it should be an async function. It seems like it would make sense as a sync function. We can expect a receipt as the argument and we wouldn't need to await it.

[nventuro]

I don't see a point in making it async, since you'll need to await on your test anyway.

[Aniket-Engg]

inLogs should be removed only from module.exports and used internally for inTransaction or it should be removed completely and functionality of inLogs should be added in inTransaction?

[nventuro]

@Aniket-Engg that's an implementation detail of the helper, use your best judgment :) I think we could safely put it inside inTransaction though.

[nventuro]

Closed via #1511