Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dark Themes #8

Open
3 tasks
mririgoyen opened this issue Jan 18, 2023 · 5 comments
Open
3 tasks

Support Dark Themes #8

mririgoyen opened this issue Jan 18, 2023 · 5 comments
Labels
Feature Request New feature or enhancement to existing feature

Comments

@mririgoyen
Copy link
Member

As a user of the Pictogrammers website, I would like it to respect my OS's theme setting and display the website in either a dark or light theme. Additionally, I would like to have an option to switch between the two modes.

Notes:

The structure of the CSS already is laid out to add more theme versions.

AC:

  • Add a theme-dark and define the color overrides.
  • Add logic to automatically choose the correct theme based on user setting.
  • Allow the user to toggle between light and dark mode. If this happens, remember their setting in a cookie/local storage and default to it on return visits.
@mririgoyen mririgoyen added the Feature Request New feature or enhancement to existing feature label Jan 18, 2023
@andrejsharapov
Copy link
Contributor

Hello, @mririgoyen. Is there an estimated release date for this release? I started making a small UI Kit outside of MUI to work on the current indentation system and add some elements to the design. But I would like to wait so as not to redo the elements again))

@AxelLR992
Copy link

Is someone already working on this? If not, I'd like to give it a try.

@andrejsharapov
Copy link
Contributor

Is someone already working on this? If not, I'd like to give it a try.

Yes, @mririgoyen wrote that it is in the process.

@mririgoyen
Copy link
Member Author

The site is architecturally changing to support features behind authentication. Attempting to do this now would be counterproductive IMO. There are also branding considerations we need to work out in terms of acceptable color palette. I'm honestly tempted to close this as "Won't Fix" for now and revisit it at a much later time.

@andrejsharapov
Copy link
Contributor

andrejsharapov commented Mar 13, 2023

This is a good decision. I see you made the shape of the buttons in the navigation less round as I intended). I will then wait with my proposals when this is completed so as not to interfere. But I want to share a couple of thoughts:

  • On the "About" page, it might be worth removing the breadcrumbs.
  • Develop a design system as pages have margin/padding issues (e.g. LandingPageHeading looks great, but the content below takes up more width and this creates a visual imbalance), etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or enhancement to existing feature
Projects
None yet
Development

No branches or pull requests

3 participants