Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] smslink_nc #14120

Closed
pipedream-component-development opened this issue Sep 27, 2024 · 4 comments · Fixed by #14261
Closed

[Components] smslink_nc #14120

pipedream-component-development opened this issue Sep 27, 2024 · 4 comments · Fixed by #14261
Assignees
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@pipedream-component-development
Copy link
Collaborator

pipedream-component-development commented Sep 27, 2024

smslink_nc

URLs

Actions

create-contact

Prompt

Create a new contact.

URLs

delete-contact

Prompt

Delete a contact.

URLs

create-sms-campaign

Prompt

Create a new SMS campaign.

URLs

delete-sms-campaign

Prompt

Delete a SMS campaign.

URLs

@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Oct 2, 2024
@jcortes jcortes self-assigned this Oct 8, 2024
@jcortes jcortes moved this from To Do to Doing in Component (Source and Action) Backlog Oct 8, 2024
@jcortes
Copy link
Collaborator

jcortes commented Oct 9, 2024

To QA: I couldn't test Create SMS Campaign because I was getting the following error as the response:

{
  "message": "Failed validation attempt.",
  "errors": {
    "sender": [
      "The sender is invalid."
    ]
  },
  "object": {
    "title": "Test 1",
    "sender": "SMSLink",
    "text": "Test 1 http://smss.nc/STOPP",
    "auto_optimize_text": true,
    "recipients": [
      {
        "phone_number": 756587
      },
      {
        "phone_number": 756583
      },
      {
        "phone_number": 756581
      }
    ],
    "client_id": 255,
    "purpose": "marketing"
  }
}

And it seems like there is some kind of issue in the API endpoint because that's actually the value that is in their example in the documentation. So let me know if I should remove this action in the case you don't find the issue here.

Also just in any case the mobile phone numbers that I found worked for testing are the following: 756581, 756583 and 756587

@jcortes jcortes moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Oct 9, 2024
@jcortes jcortes moved this from Ready for PR Review to Doing in Component (Source and Action) Backlog Oct 10, 2024
@jcortes jcortes moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Oct 10, 2024
@GTFalcao GTFalcao moved this from Ready for PR Review to In Review in Component (Source and Action) Backlog Oct 11, 2024
@GTFalcao GTFalcao moved this from In Review to Ready for QA in Component (Source and Action) Backlog Oct 11, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Oct 14, 2024
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog Oct 14, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-smslink_nc-11cbf548bb5e81e193f3fe27b7fe913d

@jcortes
Copy link
Collaborator

jcortes commented Oct 14, 2024

Hi @vunguyenhung I'm removing the action Create SMS Campaign due to the The sender is invalid error

@jcortes jcortes moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Oct 14, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Oct 15, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Oct 15, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Components-smslink_nc-11cbf548bb5e81e193f3fe27b7fe913d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging a pull request may close this issue.

3 participants