Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the logic for generation and parsing and user interaction #12

Open
kunaltyagi opened this issue Oct 25, 2020 · 3 comments
Open

Comments

@kunaltyagi
Copy link
Member

kunaltyagi commented Oct 25, 2020

Make a single script that handles staged as well as end-2-end generation of assets

This will allow there to be 4 components:

  • parsing (common)
  • user interaction for parsing, gen, compilation. This will also be hopefully common
  • library-dependent (eg: pybind11)
    • generation
    • compilation

Split off from #11

This involves creating a separate script, addressing the issue with compile_database_path and adding a simple cmake generator

@kunaltyagi
Copy link
Member Author

@divmadan Could you please post a simple CMake example for compiling the generated cpp file?

@diivm
Copy link
Collaborator

diivm commented Oct 29, 2020

@kunaltyagi
Is this what you are looking for?

 cmake_minimum_required(VERSION 3.5) 
 project(bindings) 

 find_package(PCL COMPONENTS common REQUIRED) # depends on usage

 # We can replace `find_package` with `add_subdirectory`, depending on usage. 
 # https://pybind11.readthedocs.io/en/stable/compiling.html#find-package-vs-add-subdirectory  
 find_package(pybind11)

 pybind11_add_module(pcl binded_file.cpp) 
 target_link_libraries(pcl PRIVATE ${PCL_LIBRARIES}) 

There's one in the project too: https://github.com/PointCloudLibrary/clang-bind/blob/master/bindings/python/CMakeLists.txt

@kunaltyagi
Copy link
Member Author

Status: added an interface.py

Needs to route all actions through that (and modify the README to reflect that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants