Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Push-Location, Pop-Location, Get-Location -stack #3775

Closed
1 task done
LukasMarsch opened this issue Aug 8, 2023 · 1 comment
Closed
1 task done
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. Resolution-External

Comments

@LukasMarsch
Copy link

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

This was first proposed in Powershell/Powershell #19775. I was redirected here to negotiate who should implement this improvement.

Essentially this is a functionality change to keep in line with the GNU Bash Reference for these particular cmdlets.
This is not a full list of necessary changes to completely adhere to GNU Bash Reference but rather the core features.

Get-Location -stack

(this should really be a seperate Get-DirectoryStack command)

  • first item is always the current directory
  • list the stack with indexes [ -v ]
  • list single items by index (positive and negative indexing) this could be a positional parameter [ -i | -index ]
  • clear the whole stack [ -c | -clear ]

Pop-Location

  • flag to suppress change of directory after removing item [ -n ]
  • remove item by index (positive and negative indexing) - positional parameter, default value = 0, [ -i | -index ]

Push-Location

  • flag to suppress change of directory when pushing [ -n ]
  • rotating the stack, positional parameter, default value = 0 [ -i | -index ]

Proposed technical implementation details (optional)

No response

@LukasMarsch LukasMarsch added the Issue-Enhancement It's a feature request. label Aug 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Aug 8, 2023
@daxian-dbw
Copy link
Member

Pop-Location and Push-Location are PowerShell cmdlets, not belonging to the PSReadLine module.
If those improvements are to be made, they should be made in PowerShell.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Aug 8, 2023
@daxian-dbw daxian-dbw added Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. Resolution-Declined The enhancement request is declined. Resolution-External and removed Resolution-Declined The enhancement request is declined. labels Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. Resolution-External
Projects
None yet
Development

No branches or pull requests

2 participants