-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colour selections fail accessibility guidelines #3828
Comments
I think you can change PSReadline options:
Any colors. The example colors is just example. |
@237dmitry Thank you so much! Excellent tip! Doesn't let MS off the hook for not having a default accessibility compatible scheme of course but does help work around it ;-). |
@papadeltasierra Can you please upgrade to v2.3.4 of PSReadLine? We updated the default inline prediction color to provide more contrast, and I'd love to know how that works for you. To upgrade, simply run this command: |
Sorry, didn't spot the prompt for feedback in amongst all the other GitHub SPAM I received from Microsoft. I did the upgrade but the colours appear to be identical, in fact it backed out my change to the prediction colour setting and set if back to the unreadable pale colour. Microsoft has some open-source tools that check for accessibility (in this case mainly contrast that I tried against some of the colours and let's just say the tool was not impressed. |
Also don't see the "Reopen Issue" button on this page - is it disabled? |
@papadeltasierra thanks for replying back. Can you please share your changes to the prediction color setting, so that we know what color settings work for you? |
The one I used was this:
It is the same as I do appreciate that it can be nice to have colours but colours are one of the things I hate most about people doing helpful things to Linux consoles for example. They often enable colours without realising that colourblind folk sometimes cannot read the new colours text. The Microsoft tools seem to be quite good at making a decision as to what colour combinations will work and which won't and if you are able to access it, the https://accessibilityinsights.io/ tool can check all the colours for you (you might have to do this one by one) and give you a idea of what is good, or not. I ran it by running |
@papadeltasierra Thank you so much for your detailed reply! Accessibility is of high importance to us and admittedly, we are not doing very good about it in PSReadLine today. The information you provided here will be very helpful to us. BTW, you mentioned that the inline prediction color works for you is |
Sorry, looks like I somehow lost my change. Fortunately I was able to find the history and the selection I went with was |
Prerequisites
Steps to reproduce
PowerShell 7.3.7. Use some commands and trigger "hint" text. For example see the image below:
As someone who is slightly colourblind, I can barely see the help text and it certainly does not pass accessibility guidelines according to Accessibility Insights for Windows.
I have tried changing the colour scheme but they all seem to suffer from similar issues and I could not find one that made all the test have a good contrast.
Expected behavior
Text should all be easily readable, albeit perhaps with a need to select a "high contrast" colour scheme.
Actual behavior
Various different text colours, of which the help text is one example, are hard if not impossible to read.
Error details
None.
Environment data
Visuals
The text was updated successfully, but these errors were encountered: