-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger relies on case-insensitive paths #2047
Comments
Well would you look at that, someone somewhere is enforcing this behavior: |
Yup, it's an intentional VS Code design decision which means I doubt I can get it fixed upstream: microsoft/vscode#40057 |
Per @jrieken in microsoft/vscode#68325 (comment), this has been brought up as breaking others before, but the decision is "something we cannot change anymore." In summary, this isn't something PSES or vscode-powershell is doing wrong, it's a consequence of receiving URIs from VS Code where they enforce the drive-letter being lowercase, and this does not match up with PowerShell's own expectation that the drive-letter is upper-case. So @fflaten I think that when PowerShell/PowerShell#20057 is fixed to support distinguishing files in the PowerShell debugger on case-sensitive filesystems, the simplest answer is to fix it only when on a case-sensitive filesystem. I don't like the idea of trying to handle this in PSES be re-upper-casing drive letters in each and every handler; we're going to miss something and things will suspiciously break again. |
This odd behavior was first noticed in a test:
PowerShellEditorServices/test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs
Lines 140 to 141 in bfe334d
It turns out that the URIs and paths we're receiving "over the wire" (in the raw LSP requests themselves) are mostly cased correctly, with the exception of driver letters being lower case. Because of this, when PowerShell/PowerShell#20057 was temporarily fixed by making PowerShell's debugger's
_pendingBreakpoints
collection case-sensitive, it broke the extension's debugger PowerShell/vscode-powershell#4668.We need to figure out why those drive letters are coming over lower-case, as the rest of the Windows ecosystem doesn't expect drive letters to be lowercase. Worst case scenario is that we fix the casing as we handle the request, but I'd like to see where the issue originates (thinking perhaps in the LSP client library...) and try to fix it there. Though technically
c:/
is valid, and it's mostly PowerShell that's caring about it not beingC:/
.The text was updated successfully, but these errors were encountered: