Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [ymodem] last frame's data_sz issue. (soh, stx) #9479

Open
sulfurandcu opened this issue Sep 27, 2024 · 1 comment
Open

[Bug] [ymodem] last frame's data_sz issue. (soh, stx) #9479

sulfurandcu opened this issue Sep 27, 2024 · 1 comment

Comments

@sulfurandcu
Copy link
Contributor

RT-Thread Version

trunk

Hardware Type/Architectures

all

Develop Toolchain

Microsoft VScode

Describe the bug

when ymodem receiving last frame in function _rym_do_fin(),
in my opinion:

  • if code is SOH, it should receive another _RYM_SOH_PKG_SZ-1 long data,
  • if code is STX, it should receive another _RYM_STX_PKG_SZ-1 long data,

but now it will receive _RYM_SOH_PKG_SZ-1 no matter what code is.
is there a bug or is the design like this?

图片

Other additional context

No response
@mysterywolf
Copy link
Member

Could you submit a PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sulfurandcu @mysterywolf