Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Hash for enum-like structs #121

Open
rib opened this issue Aug 28, 2022 · 1 comment
Open

Derive Hash for enum-like structs #121

rib opened this issue Aug 28, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rib
Copy link

rib commented Aug 28, 2022

It could be convenient if most of the structs for enum-like constants, such as EnvironmentBlendMode implemented Hash.

While experimenting, I initially went to put the supported blend modes in a HashSet with the intention to check (on-the-fly) if an app was able to switch between opaque vs pass-through rendering. Easy enough to workaround but still it could be convenient.
@Ralith Ralith added enhancement New feature or request good first issue Good for newcomers labels Aug 29, 2022
@Ralith
Copy link
Owner

Ralith commented Aug 29, 2022

I'd be happy to merge a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ralith @rib