Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data missing in some columns in JSON preview #292

Closed
CherryDT opened this issue Sep 15, 2021 · 8 comments
Closed

Data missing in some columns in JSON preview #292

CherryDT opened this issue Sep 15, 2021 · 8 comments
Labels
wontfix This will not be worked on

Comments

@CherryDT
Copy link

CherryDT commented Sep 15, 2021

See screenshot:
image

As you can see, the phone and ctecId columns are missing their data in the preview.

This is the JSON data:

[
  {
    "prontoId": 0,
    "email": "[email protected]"
  },
  {
    "prontoId": 1,
    "email": "[email protected]"
  },
  {
    "prontoId": 2,
    "email": "[email protected]",
    "phone": "1234567890",
    "ctecId": "A123456"
  },
  {
    "prontoId": 3,
    "email": "[email protected]",
    "phone": "0987654321",
    "ctecId": "A654321"
  },
  {
    "prontoId": 4,
    "email": "[email protected]"
  },
  {
    "prontoId": 5,
    "email": "[email protected]",
    "phone": "1112223333"
  }
]
@RandomFractals
Copy link
Owner

RandomFractals commented Aug 25, 2022

This is related to #238 and is because your first two data entries in that json array doesn't have phone or ctecId properties.

if you add blanks there, it should work. Data preview doesn't scan random rows or first 10 or 100 rows to infer table columns yet.

Columns are determined by the first record in your dataset and it's important that you have all the properties and correct types in your first record.

@CherryDT
Copy link
Author

Hm, what you say doesn't make sense though, because the columns are displayed... just empty.

@RandomFractals
Copy link
Owner

RandomFractals commented Aug 25, 2022

@CherryDT have you tried adding those missing properties with empty string values?

@CherryDT
Copy link
Author

CherryDT commented Aug 25, 2022

Yes it works then.

But what I mean is this: If the columns are based on what's in the first record, then why are phone and ctecId displayed as columns nonetheless? Even more interestingly, it seems like there are even types deferred somehow, because phone is shown as number type on the left sidebar...

If the columns simply weren't there, it would be clearer what's going on...

@RandomFractals RandomFractals added the wontfix This will not be worked on label Aug 25, 2022
@RandomFractals
Copy link
Owner

RandomFractals commented Aug 25, 2022

that is the current limitation and since I'll be updating some of the dependencies in this extension soon, I don't think it's worthwhile to dig in deeper here.

So, I am going to close this for now. Just make sure all your records have the property fields you'd like to view and filter.

@lyons-g
Copy link

lyons-g commented Feb 13, 2023

Hi, when you say you'll be updating some of the dependencies soon, will this limitation be addressed?

@RandomFractals
Copy link
Owner

Hi, when you say you'll be updating some of the dependencies soon, will this limitation be addressed?

yes. I am currently working on new duckdb tools, and plan to get back to data preview in March/April.

@lyons-g
Copy link

lyons-g commented Feb 13, 2023

Hi, when you say you'll be updating some of the dependencies soon, will this limitation be addressed?

yes. I am currently working on new duckdb tools, and plan to get back to data preview in March/April.

Great - thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants