New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifier string parse/encode incompatibility #1235

Open

kralverde opened this issue Jun 15, 2023 · 0 comments

Contributor

kralverde commented Jun 15, 2023

Currently, verifier strings are limited to 80 characters. Making a null tag vout for a verifier uses OP_PUSH (

Ravencoin/src/assets/assets.cpp

Line 4567 in e48d932

script << OP_RVN_ASSET << OP_RESERVED << ToByteVector(vchMessage);

). Reading the verifier hardcodes an allotment of 1 byte for length (

Ravencoin/src/assets/assets.cpp

Line 901 in e48d932

    
           vchAssetData.insert(vchAssetData.end(), scriptPubKey.begin() + OFFSET_THREE, scriptPubKey.end());

). The last 1-byte OP_PUSH is 0x4b (75 dec) making this de-facto the longest verifier string as longer will error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment