Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require service_identity for better TLS client hostname verification #226

Open
mayukh18 opened this issue Oct 21, 2017 · 1 comment
Open

Require service_identity for better TLS client hostname verification #226

mayukh18 opened this issue Oct 21, 2017 · 1 comment
Labels
question

Comments

@mayukh18
Copy link

This warning gets shown when trying to run the server
:0: UserWarning: You do not have a working installation of the service_identity module: 'No module named service_identity'. Please install it from <https://pypi.python.org/pypi/serv ice_identity> and make sure all of its dependencies are satisfied. Without the service_identity module, Twisted can perform only rudimentary TLS client hostname verification. Many valid certificate/hostname mappings may be rejected.

@nirs
Copy link
Member

nirs commented Oct 21, 2017

We don't support TLS now, and I don't think there is a need for TLS in this application.
I don't see this warning on Fedora 25 with twisted 17.9.0 (or with older twisted).

@mayukh18, can you give more details on the system you run this and twisted version?

@nirs nirs changed the title Add service_identity in requirements.txt Require service_identity for better TLS client hostname verification Oct 21, 2017
@nirs nirs added the question label Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nirs @mayukh18