Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default --region should come from the profile #22

Open
tbooth opened this issue Oct 21, 2022 · 1 comment
Open

Default --region should come from the profile #22

tbooth opened this issue Oct 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@tbooth
Copy link

tbooth commented Oct 21, 2022

If no --region is specified on the command line the default is hard coded to 'us-east-1'. The region set in the profile is ignored, and also the standard AWS_DEFAULT_REGION environment variable is ignored.

Given that the default behaviour of calling boto3.session.Session(region_name=None) is to respect both these settings, this would be a more logical default.

Thanks for maintaining dsnap!

@tbooth tbooth added the bug Something isn't working label Oct 21, 2022
@RyanJarv
Copy link
Contributor

RyanJarv commented Oct 27, 2022

Thanks! Agreed, None should have be the default here. I think we'll just want to update the major version when we do this just because I think it can fail if the region isn't set in ~/.aws/config.

Note to self: us-east-1 is set as the default in a few places across the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants