Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompute correct store type for operations #213

Open
saik0 opened this issue Feb 14, 2022 · 0 comments
Open

Precompute correct store type for operations #213

saik0 opened this issue Feb 14, 2022 · 0 comments

Comments

@saik0
Copy link
Contributor

saik0 commented Feb 14, 2022

This optimization has been unblocked by #168

For operations that could cause a conversion between store types we can first compute the cardinality of the op. The operation can then continue, using the correct store type, removing the need to ensure_correct_store.

This will make the best-case slower, but the worst-case faster. Delta for average-case will be data dependent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant