Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Add Documentation for PrintOptions #1941

Closed
shbenzer opened this issue Sep 12, 2024 · 8 comments
Closed

[🚀 Feature]: Add Documentation for PrintOptions #1941

shbenzer opened this issue Sep 12, 2024 · 8 comments

Comments

@shbenzer
Copy link
Contributor

Feature and motivation

From what I've seen, the documentation and use cases for Selenium's PrintOptions class is rather limited. I think the community would benefit from the team expanding on this.

https://www.selenium.dev/selenium/docs/api/java/org/openqa/selenium/print/PrintOptions.html

Copy link
Contributor

@shbenzer, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@shbenzer
Copy link
Contributor Author

shbenzer commented Oct 8, 2024

@harsha509 do you think this should be added to it's own sub-section in the documentation under WebDriver?

@shbenzer
Copy link
Contributor Author

shbenzer commented Oct 8, 2024

or we could add a section on "Augmenting the Webdriver" where we also add documentation for classes like WebStorage, Augmenter, etc.

@harsha509
Copy link
Member

Hi @shbenzer ,

How about adding new section under Browser interactions named "Print Page"

@shbenzer
Copy link
Contributor Author

shbenzer commented Oct 8, 2024

That works!

@shbenzer
Copy link
Contributor Author

Closed with #1987

@shbenzer shbenzer reopened this Oct 13, 2024
@shbenzer
Copy link
Contributor Author

shbenzer commented Oct 13, 2024

Going to add examples for Python and C# before closing since it's implemented in those languages as well as java. Then put PrintOptions in one section, then actually Printing in another

@shbenzer
Copy link
Contributor Author

shbenzer commented Nov 3, 2024

Can now be closed - other languages are missing implementations. With completion of implementations in other languages, the badge codes should be sufficient

@shbenzer shbenzer closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants